Review Request: QWidget-based tooltips for contact list

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103297/
-----------------------------------------------------------

(Updated Dec. 2, 2011, 11:21 a.m.)


Review request for Telepathy.


Changes
-------

Added few validity checks to prevent crashes and used K_GLOBAL_STATIC (hopefully correctly :)


Description
-------

This is the result of Google Code-in student Geoffry Song's work, based on David's code (which was stolen from system settings). The tooltips works perfectly, the code is great quality as well, though as it is rather big diff, I'd like to have more eyes on it.


Diffs (updated)
-----

  CMakeLists.txt 68dc90c 
  abstract-contact-delegate.cpp 2bd0f55 
  main-widget.cpp 7f0adf1 
  tooltips/contacttooltip.h PRE-CREATION 
  tooltips/contacttooltip.cpp PRE-CREATION 
  tooltips/contacttooltip.ui PRE-CREATION 
  tooltips/ktooltip.h PRE-CREATION 
  tooltips/ktooltip.cpp PRE-CREATION 
  tooltips/ktooltipwindow.cpp PRE-CREATION 
  tooltips/ktooltipwindow_p.h PRE-CREATION 
  tooltips/tooltipmanager.h PRE-CREATION 
  tooltips/tooltipmanager.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/103297/diff/diff


Testing
-------

I've been using it for two days now and all hail to Geoffry, who did really awesome job.


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111202/90cda2f8/attachment.html>