Review Request: Make the abstractContactDelegate behave like an actual abstract class. Simplifies the code in the two actual delegates.

David Edmundson kde at davidedmundson.co.uk
Wed Aug 10 13:59:50 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102282/
-----------------------------------------------------------

Review request for Telepathy.


Summary
-------

Make the abstractContactDelegate behave like an actual abstract class. Simplifies the code in the two actual delegates.


Fix a bug in which group header text and horizontal line can overlap with the account icon


Diffs
-----

  abstract-contact-delegate.h b6dcfc8 
  abstract-contact-delegate.cpp 309910d 
  contact-delegate-compact.h 4387e0c 
  contact-delegate-compact.cpp 4415af8 
  contact-delegate.h bc81bd4 
  contact-delegate.cpp e75d094 

Diff: http://git.reviewboard.kde.org/r/102282/diff


Testing
-------


Thanks,

David

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20110810/b0a3e4f4/attachment.html>


More information about the KDE-Telepathy mailing list