Review Request: Re-establish chat after going offline and back online PART 3 of 3
David Edmundson
kde at davidedmundson.co.uk
Sat Apr 30 19:48:22 CEST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101260/#review2991
-----------------------------------------------------------
Ship it!
Perfect.
- David
On April 30, 2011, 5:19 p.m., Francesco Nwokeka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101260/
> -----------------------------------------------------------
>
> (Updated April 30, 2011, 5:19 p.m.)
>
>
> Review request for Telepathy.
>
>
> Summary
> -------
>
> Final part of bug 270725: An existing chat window/tab stops working when going offline and back online. When user goes offline, the chat is invalidated. If the user comes back online, and the previous chat window is still open, the chat with that contact is re-established.
>
>
> This addresses bug 270725.
> http://bugs.kde.org/show_bug.cgi?id=270725
>
>
> Diffs
> -----
>
> app/chat-tab.h 17924cc
> app/chat-tab.cpp 8f5226e
> app/chat-window.h ebbcca9
> app/chat-window.cpp 7d82066
> app/telepathy-chat-ui.cpp 5473394
> lib/chat-widget.h 0a4cb1a
> lib/chat-widget.cpp 148f4e4
>
> Diff: http://git.reviewboard.kde.org/r/101260/diff
>
>
> Testing
> -------
>
> Went offline and back online. Chat was automatically re-established
>
>
> Thanks,
>
> Francesco
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110430/eefd5639/attachment.htm
More information about the KDE-Telepathy
mailing list