Review Request: Re-establish chat after going offline and back online PART 2 of 3

Francesco Nwokeka francesco.nwokeka at gmail.com
Sat Apr 30 04:14:12 CEST 2011



> On April 30, 2011, 2:01 a.m., David Edmundson wrote:
> > lib/chat-widget.h, line 59
> > <http://git.reviewboard.kde.org/r/101255/diff/1/?file=15609#file15609line59>
> >
> >     const Tp::TextChannelPtr &newTextChannelPtr
> >     
> >     (before Dario spots it)

Done


- Francesco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101255/#review2977
-----------------------------------------------------------


On April 30, 2011, 1:40 a.m., Francesco Nwokeka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101255/
> -----------------------------------------------------------
> 
> (Updated April 30, 2011, 1:40 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> If a textChannel is invaldiated by the user going offline and then, once back online, requests a chat with the same person, the channel is re-established.
> 
> 
> Diffs
> -----
> 
>   app/chat-window.cpp 3d14909 
>   lib/chat-widget.h f7d08d3 
>   lib/chat-widget.cpp ef4927c 
> 
> Diff: http://git.reviewboard.kde.org/r/101255/diff
> 
> 
> Testing
> -------
> 
> started chat, went offline and back online, reopened chat with same contact.
> 
> 
> Thanks,
> 
> Francesco
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110430/046351d4/attachment.htm 


More information about the KDE-Telepathy mailing list