Review Request: Re-establish chat after going offline and back online PART1

Francesco Nwokeka francesco.nwokeka at gmail.com
Fri Apr 29 02:26:59 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101250/
-----------------------------------------------------------

(Updated April 29, 2011, 12:26 a.m.)


Review request for Telepathy.


Changes
-------

Made adjustments to previous code as suggested by reviews.


Summary
-------

Part1 of resolving bug 270725. I made two setup methods that have the task to setup the connections of the chatWidget's Tp::textChannelPtr. This was done to facilitate my work later on when substituting the old textptr with a new one when the user comes back online and he/she had an ongoing chat.
Plus you can see that I changed the mathing criteria. I no longer match the textChannelPtr, but the targetId and it's handler.


Diffs (updated)
-----

  app/chat-window.h 8a55655 
  app/chat-window.cpp ca1778a 
  lib/chat-widget.h f357aea 
  lib/chat-widget.cpp b483436 

Diff: http://git.reviewboard.kde.org/r/101250/diff


Testing
-------

Opened chats with contacts and the behaviour was like before


Thanks,

Francesco

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110429/0e4c8ba3/attachment.htm 


More information about the KDE-Telepathy mailing list