Review Request: Re-establish chat after going offline and back online PART1

[Dario Freddi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101250/#review2947
-----------------------------------------------------------



app/chat-window.cpp
<http://git.reviewboard.kde.org/r/101250/#comment2525>

    Use ++index as per code policy



app/chat-window.cpp
<http://git.reviewboard.kde.org/r/101250/#comment2526>

    Cannot really comment on that, but if the channel has already been invalidated, it should not report useful infos.


- Dario


On April 28, 2011, 3:32 p.m., Francesco Nwokeka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101250/
> -----------------------------------------------------------
> 
> (Updated April 28, 2011, 3:32 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Part1 of resolving bug 270725. I made two setup methods that have the task to setup the connections of the chatWidget's Tp::textChannelPtr. This was done to facilitate my work later on when substituting the old textptr with a new one when the user comes back online and he/she had an ongoing chat.
> Plus you can see that I changed the mathing criteria. I no longer match the textChannelPtr, but the targetId and it's handler.
> 
> 
> Diffs
> -----
> 
>   app/chat-window.h 8a55655 
>   app/chat-window.cpp ca1778a 
>   lib/chat-widget.h f357aea 
>   lib/chat-widget.cpp b483436 
> 
> Diff: http://git.reviewboard.kde.org/r/101250/diff
> 
> 
> Testing
> -------
> 
> Opened chats with contacts and the behaviour was like before
> 
> 
> Thanks,
> 
> Francesco
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110428/e6709bfa/attachment.htm