Review Request: Update display name after modifying the account

Commit Hook null at kde.org
Mon Apr 25 07:55:35 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101228/#review2878
-----------------------------------------------------------


This review has been submitted with commit a99743e8f9a85f7ce9735e4131d830ef4813aee7 by Daniele E. Domenichelli.

- Commit


On April 24, 2011, 11:46 p.m., Daniele Elmo Domenichelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101228/
> -----------------------------------------------------------
> 
> (Updated April 24, 2011, 11:46 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> When an account is modified, the display name is not updated, so if the account is modified, the display name will show the old account name instead of the new one.
> This patch updates the display name every time the parameters are updated (using the same displayName value used in add-account-assistant.cpp:170)
> 
> 
> Diffs
> -----
> 
>   src/edit-account-dialog.h 35db80366717ae6b71b8b94637612b5dca06d251 
>   src/edit-account-dialog.cpp edf41bf7f11030467b4a25bbcdb865048bcef3bb 
> 
> Diff: http://git.reviewboard.kde.org/r/101228/diff
> 
> 
> Testing
> -------
> 
> Builds, and display name is modified when the account is modified.
> 
> 
> Thanks,
> 
> Daniele Elmo
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110425/648fec76/attachment.htm 


More information about the KDE-Telepathy mailing list