Review Request: Accounts KCM Plugin for GoogleTalk

[Dario Freddi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101189/#review2861
-----------------------------------------------------------

Ship it!



gabble/main-options-widget-googletalk.h
<http://git.reviewboard.kde.org/r/101189/#comment2487>

    This should go right below Q_OBJECT (code style)


- Dario


On April 23, 2011, 2:15 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101189/
> -----------------------------------------------------------
> 
> (Updated April 23, 2011, 2:15 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Technically this isn't a plugin but simply a different UI form for the main options widget for Jabber accounts in gabble.
> 
> This may look like an incredibly OTT way to change a single label from the normal jabber view, but for Facebook I need to do some much more complex wizzardry, and this puts the framework in place for that.
> 
> 
> Diffs
> -----
> 
>   gabble/CMakeLists.txt 53a7ee668cce2680f61ed931fccbc4aab8844562 
>   gabble/gabble-account-ui-plugin.cpp 344ca2e4ab5d0be5285e2f0f5227b535057aa6ba 
>   gabble/gabble-account-ui.h 32e433916fb962feee0af4a22d7f992c615a6552 
>   gabble/gabble-account-ui.cpp 4f6a8a3f6a0f839eb3cdf3e78ba64774ed56bfa2 
>   gabble/main-options-widget-googletalk.h PRE-CREATION 
>   gabble/main-options-widget-googletalk.cpp PRE-CREATION 
>   gabble/main-options-widget-googletalk.ui PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/101189/diff
> 
> 
> Testing
> -------
> 
> Edited a GoogleTalk account, checked that the label said "Email address" rather than "Jabber ID:" to make sense to GMail users.
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110424/d406c900/attachment.htm