[Bug 270725] An existing chat window/tab stops working when going offline and back online

David Edmundson kde at davidedmundson.co.uk
Sat Apr 23 13:31:31 CEST 2011


https://bugs.kde.org/show_bug.cgi?id=270725





--- Comment #3 from David Edmundson <kde davidedmundson co uk>  2011-04-23 13:31:30 ---
For resuming in the same window we need the following:

 - a method in ChatWidget called setChannel(Tp::TextChannel) which will
correctly replace the channel object for a new one, and update/reconnect
_everything_. The original code wasn't designed for this, so this may be a
tricky task. This should undo any disabling that happened when the first
channel became invalidated.

 - a method in the ChatWidget to expose a set of contact IDs we are/were
talking to.

 - The chat app needs to search through all the windows and look for anything
with matching contacts _IDs_ (don't compare Tp::ContactPtrs as the first set
become invalidated when you went offline)

We already have code that checks for matching channels, I'm not sure if we then
should remove that, as it's doing effectively the same thing (in a
faster+better way, but one that only works whilst the first channel is
connected)

Possible future bug: if we do it like I described, there is a slim chance that
if we join a room which just happens to have exactly the same people in it, it
would open in the same window. Not sure how to fix that, maybe we should only
do it for 1-1 chats?

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the KDE-Telepathy mailing list