Review Request: Disable non-editable edit fields where the value comes from a profile

David Edmundson kde at davidedmundson.co.uk
Sat Apr 23 02:00:23 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101184/
-----------------------------------------------------------

Review request for Telepathy.


Summary
-------

Disable non-editable edit fields where the value comes from a profile 

+ some very minor whitespace fixes elsewhere in the same file


Diffs
-----

  src/KCMTelepathyAccounts/parameter-edit-model.cpp 441b6e58daf13b3fcf65ab344544ae36e50b940b 
  src/KCMTelepathyAccounts/parameter-edit-model.h ecd04e7b2aa7670a89b5fbf264c177df27c9057b 
  src/KCMTelepathyAccounts/abstract-account-parameters-widget.cpp d28b4f3fed227aa2b15342f4b9312c02b8babea9 

Diff: http://git.reviewboard.kde.org/r/101184/diff


Testing
-------

Tried creating a facebook and general jabber account. In facebook the server name and port number were greyed out.


Thanks,

David

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110423/dfabadbb/attachment.htm 


More information about the KDE-Telepathy mailing list