Review Request: Misc fixes for telepathy-contact-list

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101179/#review2830
-----------------------------------------------------------

Ship it!


Great work, thanks!


contact-model-item.h
<http://git.reviewboard.kde.org/r/101179/#comment2470>

    We should probably also unify the email address format..


- Martin


On April 22, 2011, 2:04 p.m., Dario Freddi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101179/
> -----------------------------------------------------------
> 
> (Updated April 22, 2011, 2:04 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Decently sized branch with lots of misc fixes and stuff. Will let git cherry explain that for me:
> 
> 
> + 4b5c54c7705f474aeb2b7da9eecb2f42b139aeb2 Expand only the item belonging to the account which is being connected - and collapse it upon disconnection
> + 75249599c256084302249327cc9b6b2789698a80 Cast properly: never use static_cast unless strictly required, and use qobject_cast wherever possible
> + a7431ac2081d74d4b08502483ea64240c76fe688 Includes done right: own include must always go first, moc should go to the bottom - and remember a newline at the end of the file
> + eaf348e97578fdca27cc3b78c6556f45d795f537 Always use deleteLater() on QObject except some special cases, and beware: connect() can crash if the sender is null as well.
> + f392c5d0e215f6e693166d7677948859396c9010 Add missing copyrights
> + b7b5052275d0740bda5eb87aaaaf8600d0f0eab8 AbstractWidgetDelegateOverlay: Make m_widget a QWeakPointer. Given that we strongly rely on having m_widget == 0 on deletion, just use the proper method.
> + 4a630c51036d5c47558a6561fe828b7ed456632c Remove unneeded signal handlers
> + 2dcd374ce0518570d184b2791ee53b70bc326c00 Use proper copyright tags: email instead of web address
> + f3b388bda7ed34273d8c954529b0bd2be51ab319 Fix misuse of i18n, add some context to some calls
> + 9604b357205618a2302cbff2211ed1f24012ad29 Make constructors explicit when needed
> + 4e7ef1ef7b79da894cff4a63c6f622197e86542e Fix typo
> + 8d975a87648a4fd996bd9f83113040ddbcafb2b3 Use K* classes
> 
> 
> Diffs
> -----
> 
>   account-button.h 451af7e1af9a3a70557416ffb7c8d301fb9ec10b 
>   account-button.cpp db00d7bd6b19a15425757052bc788d1b4232e51e 
>   account-filter-model.cpp 8ca65612b67eec4a9dff4791ac6ff591738ea019 
>   accounts-model-item.h 1f99064c60da09a4a2c4ac7b750db14c460f9d63 
>   accounts-model-item.cpp 33e44671e89fbca27c11b8713240442ea36ff2c6 
>   accounts-model.h 42cc2b24e580838448fb0fae865540f3f54cc802 
>   accounts-model.cpp 366c46fc8b765c56b31709e535758991f1d9e329 
>   add-contact-dialog.h c9bfbd0f4bd03dc67854a3f09c2388048f5431b3 
>   add-contact-dialog.cpp 6dd32d2ff568b8d30bf9276ae39605e2a0dc5cf4 
>   add-contact-dialog.ui 637537d5da93db069f167c5bf0be63e589757ef6 
>   contact-delegate-overlay.h 5c5e29546aa0b988a79684084eede7e409317553 
>   contact-delegate-overlay.cpp d56b36d979d2f3c7221fbc13cd47ec6730580f37 
>   contact-delegate.h 2a3703d5335a9424bfcded5cc97eec701f08a56c 
>   contact-delegate.cpp 705f80053f1e524cb62cfe092fe7637f47d35b0f 
>   contact-model-item.h eceb054f480e1df60d6b2ae8fd8e355645cab525 
>   contact-model-item.cpp e77b8edceedd529c3365fa83455f09b3858f2853 
>   contact-overlays.cpp 0869ef801866039397ab2db591e83dc35696b229 
>   contact-view-hover-button.h a3e8a9d1461cf8b28a0fd643b80cd27ad015a6c7 
>   contact-view-hover-button.cpp d6bde9e96f95de46c6bbdfece4e8178e8d57d645 
>   main-widget.cpp a100c0505f094611261d08a159332df7b89d8b6e 
>   main.cpp ddc5fedc888c64bb2b39dd27d6bc03da0121bfc3 
>   remove-contact-dialog.h 2af624a31986d52595a80a26b2505e77a4271791 
>   remove-contact-dialog.cpp e6c6a8620d1acfc0701d051e7a5d2d881251dfea 
>   tree-node.h c800621b1674015402fdceaa0c0e50a899f8facd 
>   tree-node.cpp 804f4392ca0790e5c011fa27d07be715ef679621 
> 
> Diff: http://git.reviewboard.kde.org/r/101179/diff
> 
> 
> Testing
> -------
> 
> Apparently, compiles and works
> 
> 
> Thanks,
> 
> Dario
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110422/e35642e2/attachment-0001.htm