Re: Review Request: Fix bug 270476: Don‘t close filter bar when closing contact list

[Rémy Greinhofer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101181/
-----------------------------------------------------------

(Updated April 22, 2011, 5 p.m.)


Review request for Telepathy.


Changes
-------

Changes according to the remarks of the reviewers.


Summary
-------

Adding a button to the filter bar to define if this latter must be pinned or not to the contact list next time this one is launched.


This addresses bug 270476.
    http://bugs.kde.org/show_bug.cgi?id=270476


Diffs (updated)
-----

  main-widget.cpp a100c05 
  filter-bar.cpp 13102f5 
  filter-bar.h 9546c63 

Diff: http://git.reviewboard.kde.org/r/101181/diff


Testing
-------

1. Launch telepathy-contactlist, show the filter bar, check the pin button at the left, close the contact list, relaunch it, the filter bar appears.
2. Then uncheck the pin button at the left, close the contact list, relaunch it, the filter bar does not appear.


Thanks,

Rémy

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110422/70951e1c/attachment.htm