Re: Review Request: Fix bug 270476: Don‘t close filter bar when closing contact list

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101181/#review2827
-----------------------------------------------------------



filter-bar.h
<http://git.reviewboard.kde.org/r/101181/#comment2467>

    This method seems redundant as you can do the same with setPinned(false), no?



filter-bar.h
<http://git.reviewboard.kde.org/r/101181/#comment2468>

    Small nitpick in this comment - it does not pin the filter bar. It is _a button_ that pins the filter bar ;)



main-widget.cpp
<http://git.reviewboard.kde.org/r/101181/#comment2469>

    Please change this group to "GUI" as there will be more settings which controls the GUI, so let's have them all groupped together. The entry then should become "pin_filterbar.


- Martin


On April 22, 2011, 4:19 p.m., Rémy Greinhofer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101181/
> -----------------------------------------------------------
> 
> (Updated April 22, 2011, 4:19 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Adding a button to the filter bar to define if this latter must be pinned or not to the contact list next time this one is launched.
> 
> 
> This addresses bug 270476.
>     http://bugs.kde.org/show_bug.cgi?id=270476
> 
> 
> Diffs
> -----
> 
>   filter-bar.cpp 13102f5 
>   main-widget.cpp a100c05 
>   filter-bar.h 9546c63 
> 
> Diff: http://git.reviewboard.kde.org/r/101181/diff
> 
> 
> Testing
> -------
> 
> 1. Launch telepathy-contactlist, show the filter bar, check the pin button at the left, close the contact list, relaunch it, the filter bar appears.
> 2. Then uncheck the pin button at the left, close the contact list, relaunch it, the filter bar does not appear.
> 
> 
> Thanks,
> 
> Rémy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110422/2e7750df/attachment-0001.htm