Review Request: Make contact list presence subscription aware

Dario Freddi drf at kde.org
Fri Apr 22 12:39:10 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101134/
-----------------------------------------------------------

(Updated April 22, 2011, 10:39 a.m.)


Review request for Telepathy.


Changes
-------

Implemented David's fix as suggested


Summary
-------

This is a simple hack to make contact list aware of new presence subscription requests. It consists of a modal dialog - in a bright future where this will be moved out, it will be displayed as a KNotification instead. To ease the user's life, on acceptance the request is accepted and a subscription is made (a-la-windows live).


This addresses bug 270665.
    http://bugs.kde.org/show_bug.cgi?id=270665


Diffs (updated)
-----

  main-widget.h 9180d64de553487de089d7ef907b444dc742a92f 
  main-widget.cpp 305a453f5162e688e28b9345eada3cfaecea2325 

Diff: http://git.reviewboard.kde.org/r/101134/diff


Testing
-------

Briefly tested and working, needs more testing.


Thanks,

Dario

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110422/01f60836/attachment.htm 


More information about the KDE-Telepathy mailing list