Review Request: Make contact list presence subscription aware

[Dario Freddi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101134/
-----------------------------------------------------------

(Updated April 21, 2011, 1:34 p.m.)


Review request for Telepathy.


Changes
-------

Updated diff, including suggested changes by David.

This one includes multithreaded lookup of contact properties - first testing shows no issues whatsoever, but the beta cycle will tell the truth

Please, review and TEST. I had the chance to test this just briefly due to lack of accounts.


Summary
-------

This is a simple hack to make contact list aware of new presence subscription requests. It consists of a modal dialog - in a bright future where this will be moved out, it will be displayed as a KNotification instead. To ease the user's life, on acceptance the request is accepted and a subscription is made (a-la-windows live).


This addresses bug 270665.
    http://bugs.kde.org/show_bug.cgi?id=270665


Diffs (updated)
-----

  main-widget.h 9180d64de553487de089d7ef907b444dc742a92f 
  main-widget.cpp 305a453f5162e688e28b9345eada3cfaecea2325 

Diff: http://git.reviewboard.kde.org/r/101134/diff


Testing (updated)
-------

Briefly tested and working, needs more testing.


Thanks,

Dario

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110421/08dba2cb/attachment.htm