Review Request: Dependencies of the glibtests should be properly included when linking against telepathy testlib

[Dario Freddi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101154/#review2762
-----------------------------------------------------------

Ship it!


Yeah, we do :(

- Dario


On April 19, 2011, 4:16 p.m., George Goldberg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101154/
> -----------------------------------------------------------
> 
> (Updated April 19, 2011, 4:16 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> TelepathyTestlib is a static library, meaning we need to link against all its dependencies when we link to it in tests. This means we need the target libraries to include all the G* stuff that the glib tests need.
> 
> 
> Diffs
> -----
> 
>   lib/CMakeLists.txt a3a5605ba89ff5334f0cb756de0b35a9d6e324ad 
>   lib/KTelepathyTestLibConfig.cmake.in 5a41b9f7f208ca354eef41df3f644aab3658c792 
> 
> Diff: http://git.reviewboard.kde.org/r/101154/diff
> 
> 
> Testing
> -------
> 
> works here with some unit tests linking against telepathytestlib and the glib bits.
> 
> 
> Thanks,
> 
> George
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110420/02fff4fe/attachment-0001.htm