Review Request: Adding support of PageUp and PageDown for the chatArea

[Lasse Liehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101143/#review2687
-----------------------------------------------------------


A few notes to start with.


lib/chat-widget.h
<http://git.reviewboard.kde.org/r/101143/#comment2369>

    There's no event handler named this. Did you mean keyPressEvent? Btw, it exists already in master since commits.kde.org/telepathy-chat-handler/9972b54b93f68ffaa57129e670fd02486094ab66 (sorry for causing problems).



lib/chat-widget.cpp
<http://git.reviewboard.kde.org/r/101143/#comment2370>

    This is never true because the send message box is this widget's focus proxy (QWidget::focusProxy). This is actually why we need to do this special handling. QWebView handles PageUp and PageDown presses by default. This if can just be removed I think.



lib/chat-widget.cpp
<http://git.reviewboard.kde.org/r/101143/#comment2368>

    The chatArea is a subclass of QWebView, which displays a QWebPage, accessed through QWebView::page(). A page has frames (QWebFrame), the main one can be accessed using QWebPage::mainFrame(). QWebFrame then has some functions to change its scrollPosition. See: http://doc.qt.nokia.com/4.7/qtwebkit.html#architecture


- Lasse


On April 16, 2011, 7:31 p.m., Vavelin Kevin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101143/
> -----------------------------------------------------------
> 
> (Updated April 16, 2011, 7:31 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Someone tell us that PageUp and PageDown key just don't work with chatArea (and only work with sendMessageBox) so i don't know if the method uses in chatArea is the good method but i think the code is good. I don't know how we can move conversation without withdraw so let me know how to do it and i'll modify my code ;)
> 
> 
> Diffs
> -----
> 
>   app/chat-window.cpp b0a517e 
>   lib/chat-text-edit.h e1a32d3 
>   lib/chat-text-edit.cpp 54a2daa 
>   lib/chat-widget.h 9e74888 
>   lib/chat-widget.cpp e9db9b7 
> 
> Diff: http://git.reviewboard.kde.org/r/101143/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vavelin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110416/3d8ea10b/attachment.htm