Review Request: Fix bug 246223 - Filter by status proxy model

Rémy Greinhofer remy.greinhofer at gmail.com
Sat Apr 16 20:50:38 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101108/
-----------------------------------------------------------

(Updated April 16, 2011, 6:50 p.m.)


Review request for Telepathy.


Changes
-------

Modified the code according to the previous remarks.

Testing added:
3. Click on the "Show/hide offline users", the offline users do appear after the others


Summary
-------

Sorts the contacts by name offers the possibility to sort it also by status.


This addresses bug 246223.
    http://bugs.kde.org/show_bug.cgi?id=246223


Diffs (updated)
-----

  account-filter-model.h d33231d 
  account-filter-model.cpp 7182362 
  main-widget.h 310dfb6 
  main-widget.cpp 5fa5490 

Diff: http://git.reviewboard.kde.org/r/101108/diff


Testing
-------

1. Open the contact list, the contacts are sorted by name.
2. Click on the "Sort by onlineness button", the contacts are sorted by onlineness and by name.


Thanks,

Rémy

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110416/9c8f1509/attachment.htm 


More information about the KDE-Telepathy mailing list