Review Request: Make contact list presence subscription aware

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101134/#review2669
-----------------------------------------------------------

Ship it!


We're missing a step before we can close the bug report.

"Thus, in addition to listening to presencePublicationRequested(), you
should check the initial state after connecting to it, by looping over
allKnownContacts() and checking for any state = Ask contacts. These
would be in particular contacts that previously requested your presence,
perhaps when you were offline, or when you were connected to the account
earlier (maybe even with another client), but didn't approve or reject
the request then." - Oggis, mailing list thread "Add/Remove Contacts"

You can do this to build a list, then simply call your onPresencePublicationRequested method.

You can ship this as it is, as long as this doesn't get forgotten about.

Also I noticed there was nothing in the "Testing Done" field, could we make sure we give this a quick test before merging.


main-widget.cpp
<http://git.reviewboard.kde.org/r/101134/#comment2363>

    "The contact dario at hotmail.com added you to its contact list."
    
    In English we don't refer to someone as "it" and it is normally considered rude to do so.
    
    --
    
    "Do you want to allow him to see your presence"
    
    Also we can't say "him" without assuming only men are being added to your contact list.
    
    --
    
    Suggestion:
    
    "The contact %1 added you to their contact list. Do you want to allow this person to see your presence and add them to your contact list."


- David


On April 15, 2011, 4:53 p.m., Dario Freddi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101134/
> -----------------------------------------------------------
> 
> (Updated April 15, 2011, 4:53 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> This is a simple hack to make contact list aware of new presence subscription requests. It consists of a modal dialog - in a bright future where this will be moved out, it will be displayed as a KNotification instead. To ease the user's life, on acceptance the request is accepted and a subscription is made (a-la-windows live).
> 
> 
> This addresses bug 270665.
>     http://bugs.kde.org/show_bug.cgi?id=270665
> 
> 
> Diffs
> -----
> 
>   main-widget.h 310dfb6864c3efdc27a97f587595f385b3b3b2a7 
>   main-widget.cpp 5fa5490ca950d2ffcaca18b1d56b7327cbc72906 
> 
> Diff: http://git.reviewboard.kde.org/r/101134/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dario
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110416/5a44fdf8/attachment-0001.htm