Review Request: Proper avatar fetching in contact list

Dario Freddi drf at kde.org
Fri Apr 15 19:59:58 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101135/
-----------------------------------------------------------

Review request for Telepathy.


Summary
-------

This patch implements proper avatar fetching in the contact list, leaving out a FIXME. The additional class is library-ready, as it needs to be used in other places than the CL. It uses KIO to be able to fetch (asynchronously) the file from every protocol KIO supports (so even http, ftp and stuff)


Diffs
-----

  CMakeLists.txt 2b8506267a9966241d5dfb9ca2552afed11f7649 
  fetch-avatar-job.h PRE-CREATION 
  fetch-avatar-job.cpp PRE-CREATION 
  main-widget.h 310dfb6864c3efdc27a97f587595f385b3b3b2a7 
  main-widget.cpp 5fa5490ca950d2ffcaca18b1d56b7327cbc72906 

Diff: http://git.reviewboard.kde.org/r/101135/diff


Testing
-------

Needs testing, as I couldn't test myself!


Thanks,

Dario

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110415/b62daab1/attachment.htm 


More information about the KDE-Telepathy mailing list