Review Request: method name consistency changes in AccountFilterModel

[Francesco Nwokeka]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101116/#review2622
-----------------------------------------------------------

Ship it!


Looks ok to me

- Francesco


On April 14, 2011, 6:35 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101116/
> -----------------------------------------------------------
> 
> (Updated April 14, 2011, 6:35 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Renamed filterOfflineContacts -> filterOnlineContacts to match everywhere where the filter indicates what to keep.
> 
> Fix filterOnlineContacts to have a sensible name for setter method (setFilterOnlineContacts)
> 
> 
> Diffs
> -----
> 
>   account-filter-model.h d33231daac3a99b11c4411ee6fe27323bb4d3722 
>   account-filter-model.cpp 7182362ac007c72bdcc88fc7de3d6aac299d5fe9 
> 
> Diff: http://git.reviewboard.kde.org/r/101116/diff
> 
> 
> Testing
> -------
> 
> Compiled + checked behavior is the same.
> 
> (note there is an issue that the show online/offline button does the inverse of what it should do, but that's not introduced by this patch)
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110414/f858875f/attachment-0001.htm