Review Request: Add default avatar to tooltips if users don't have an avatar

[Francesco Nwokeka]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101118/#review2621
-----------------------------------------------------------



contact-delegate.cpp
<http://git.reviewboard.kde.org/r/101118/#comment2292>

    Here you hardcoded the avatar values. What happens to the avatar if I don't have a square avatar, but a rectangular one?
    I think the aspect ratio gets messed up



contact-delegate.cpp
<http://git.reviewboard.kde.org/r/101118/#comment2291>

    watch out here. Whitespace


- Francesco


On April 14, 2011, 1:37 a.m., Keith Rusler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101118/
> -----------------------------------------------------------
> 
> (Updated April 14, 2011, 1:37 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> - Fixes some lines of code
> - Resizes the avatars in the tooltips to 97x97
> - Adds a default icon for contacts that don't have an avatar
>   As requested by bug: 270492
> 
> 
> This addresses bug 270492.
>     http://bugs.kde.org/show_bug.cgi?id=270492
> 
> 
> Diffs
> -----
> 
>   contact-delegate.cpp 89514d2 
> 
> Diff: http://git.reviewboard.kde.org/r/101118/diff
> 
> 
> Testing
> -------
> 
> This adds a default avatar (im-user) to the tooltips and is resized to 97x97 to keep the tooltips at a suggested size that will keep decent. If it was any smaller, the tooltips would just look really weird similar to ones that don't have a default status message.
> 
> 
> Screenshots
> -----------
> 
> Default Avatar Tooltips
>   http://git.reviewboard.kde.org/r/101118/s/127/
> 
> 
> Thanks,
> 
> Keith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110414/d744734b/attachment.htm