Review Request: Fix bug 246223 - Filter by status proxy model

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101108/#review2597
-----------------------------------------------------------



account-filter-model.h
<http://git.reviewboard.kde.org/r/101108/#comment2277>

    Watch the coding style here - the args should be (const QModelIndex& left, const QModelIndex& right)



account-filter-model.cpp
<http://git.reviewboard.kde.org/r/101108/#comment2274>

    Watch the coding style here - the args should be (const QModelIndex& left, const QModelIndex& right)



account-filter-model.cpp
<http://git.reviewboard.kde.org/r/101108/#comment2275>

    Coding style - Put a space between the ) and {



account-filter-model.cpp
<http://git.reviewboard.kde.org/r/101108/#comment2276>

    Again - coding style :) This should be on the prev line, just after the last bracket.



main-widget.cpp
<http://git.reviewboard.kde.org/r/101108/#comment2273>

    I'm thinking if we should actually add another button to the toolbar. It's getting quite crowded there. I'll probably move it later to the Settings toolbutton menu. So leave it for now.



main-widget.ui
<http://git.reviewboard.kde.org/r/101108/#comment2272>

    The string here would be better as "Sort the contacts by status/presence". I think status will do.


- Martin


On April 12, 2011, 9:05 p.m., Rémy Greinhofer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101108/
> -----------------------------------------------------------
> 
> (Updated April 12, 2011, 9:05 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Sorts the contacts by name offers the possibility to sort it also by status.
> 
> 
> This addresses bug 246223.
>     http://bugs.kde.org/show_bug.cgi?id=246223
> 
> 
> Diffs
> -----
> 
>   account-filter-model.h d33231d 
>   account-filter-model.cpp 7182362 
>   main-widget.h 18f97ee 
>   main-widget.cpp a24ccf0 
>   main-widget.ui d000b9b 
> 
> Diff: http://git.reviewboard.kde.org/r/101108/diff
> 
> 
> Testing
> -------
> 
> 1. Open the contact list, the contacts are sorted by name.
> 2. Click on the "Sort by onlineness button", the contacts are sorted by onlineness and by name.
> 
> 
> Thanks,
> 
> Rémy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110412/02773170/attachment.htm