Review Request: Disable the chat tab when the channel is invalidated

[Dario Freddi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101105/#review2591
-----------------------------------------------------------


A pair of nitpicks, overall it looks ok


lib/chat-widget.cpp
<http://git.reviewboard.kde.org/r/101105/#comment2262>

    When using connect(), omit const and & modifiers: Qt would normalize them internally anyway, affecting performance.
    
    The right call to make is:
    
    connect(d->channel->connection().data(), SIGNAL(invalidated(Tp::DBusProxy*,QString,QString)),
                this, SLOT(onInvalidated(Tp::DBusProxy*,QString,QString)));



lib/chat-widget.cpp
<http://git.reviewboard.kde.org/r/101105/#comment2263>

    This message does not look really explainatory to me. Maybe David can suggest something better?


- Dario


On April 12, 2011, 2:26 p.m., Lasse Liehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101105/
> -----------------------------------------------------------
> 
> (Updated April 12, 2011, 2:26 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> I'm not sure about the message, but there should be some. Ideas about a better message are really appreciated. I'm also not sure if the line:
> statusMessage.setService(d->channel->connection()->protocolName());
> is good or not. I don't know what "service" is used for.
> 
> 
> This addresses bug 270725.
>     http://bugs.kde.org/show_bug.cgi?id=270725
> 
> 
> Diffs
> -----
> 
>   lib/chat-widget.h fdf5ccd 
>   lib/chat-widget.cpp af7edff 
> 
> Diff: http://git.reviewboard.kde.org/r/101105/diff
> 
> 
> Testing
> -------
> 
> 1. Open a text chat with someone
> 2. Chat
> 3. Go offline (don't close the chat window/tab)
> 4. Send message line edit and button are disabled, informational message is shown
> 
> 
> Thanks,
> 
> Lasse
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110412/989c8d4e/attachment-0001.htm