Review Request: Make the global presence message persistant (stays after close)

[Dario Freddi]

> On April 12, 2011, 1:39 p.m., Dario Freddi wrote:
> > Hmm, I don't like this. This means that any other application's changes to the presence message while the contact list stays closed would be overwritten. Can you please expand on why you want things to work this way?
> 
> Francesco Nwokeka wrote:
>     Why shouldn't this be permitted? If I change the presence message of an account from somewhere else it's because i want to change it and not to find the old one when changing app.
>     Otherwise you'll end up having a presence message "A" on the presence plasmoid and a message "B" on the contactlist for example. I don't think users would like that.
> 
> Martin Klapetek wrote:
>     Good point actually. In this case, we need some central part for storing this. That might be that another deamon which we talked about for few times - it should handle things like the "I'm listening to" plugin and it should be easily extendable by other plugins. So it could become something like central presence deamon?

Actually, you do not need that, as Telepathy does this automatically for you. You will get a signal whenever another application changes the presence message, and the presence message when you are offline is cached by TP itself, so things should already work the right way without this patch


- Dario


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101104/#review2582
-----------------------------------------------------------


On April 12, 2011, 1:10 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101104/
> -----------------------------------------------------------
> 
> (Updated April 12, 2011, 1:10 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> This patch saves the presence message so it stays when you reopen the contact list.
> 
> 
> Diffs
> -----
> 
>   main-widget.h 18f97ee 
>   main-widget.cpp 7fe200c 
> 
> Diff: http://git.reviewboard.kde.org/r/101104/diff
> 
> 
> Testing
> -------
> 
> Status message set, app reopened, status message still present
> 
> 
> Thanks,
> 
> Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110412/606c84ff/attachment.htm