Review Request: Make the global presence message persistant (stays after close)

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101104/#review2581
-----------------------------------------------------------

Ship it!


Code is fine (except a minor comment below).

I'm still not 100% convinced by your design for presence stuff, and how it interacts with 3rd parties changing the presence. However I'll wait till it's finished before judging.



main-widget.h
<http://git.reviewboard.kde.org/r/101104/#comment2258>

    Does this really need to be public?
    
    In general make things protected/private unless there's actually a reason to make it public.


- David


On April 12, 2011, 1:10 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101104/
> -----------------------------------------------------------
> 
> (Updated April 12, 2011, 1:10 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> This patch saves the presence message so it stays when you reopen the contact list.
> 
> 
> Diffs
> -----
> 
>   main-widget.h 18f97ee 
>   main-widget.cpp 7fe200c 
> 
> Diff: http://git.reviewboard.kde.org/r/101104/diff
> 
> 
> Testing
> -------
> 
> Status message set, app reopened, status message still present
> 
> 
> Thanks,
> 
> Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110412/1436c355/attachment-0001.htm