Review Request: Adds tooltips and avatar button support
Dario Freddi
drf at kde.org
Mon Apr 11 15:51:11 CEST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101012/#review2559
-----------------------------------------------------------
Overall it looks fine, leaving the final decision to the other guys
contact-delegate.cpp
<http://git.reviewboard.kde.org/r/101012/#comment2236>
Please add context to those i18n calls with i18nc
- Dario
On April 7, 2011, 11:14 p.m., Keith Rusler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101012/
> -----------------------------------------------------------
>
> (Updated April 7, 2011, 11:14 p.m.)
>
>
> Review request for Telepathy.
>
>
> Summary
> -------
>
> - Added support for tooltips when hovering over a contact in the list.
> - Added support for the avatar button at the top of the contact list.
> Now it will load the avatar when connecting, though I'm not sure on
> how to handle it if a protocol changed the avatar outside of telepathy.
> If the avatar is big it will resize it, so you don't have a huge tooltip
> when you hover your accounts.
>
>
> Diffs
> -----
>
> contact-delegate.h 20daa62
> contact-delegate.cpp 73f37e4
> main-widget.cpp 7bde815
>
> Diff: http://git.reviewboard.kde.org/r/101012/diff
>
>
> Testing
> -------
>
>
> Screenshots
> -----------
>
> Updated tooltip screenie
> http://git.reviewboard.kde.org/r/101012/s/116/
>
>
> Thanks,
>
> Keith
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110411/b92e894c/attachment.htm
More information about the KDE-Telepathy
mailing list