Review Request: Draw a border around the contact avatar

Keith Rusler xzekecomax at gmail.com
Sat Apr 9 13:40:59 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101065/#review2513
-----------------------------------------------------------


I like it


contact-delegate.cpp
<http://git.reviewboard.kde.org/r/101065/#comment2208>

    Add const to this variable if it's not going to be modified.


- Keith


On April 9, 2011, 11:34 a.m., Lukas Hetzenecker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101065/
> -----------------------------------------------------------
> 
> (Updated April 9, 2011, 11:34 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> What do you think of a small rounded border for the avatar picture of the contact?
> 
> 
> Diffs
> -----
> 
>   contact-delegate.cpp 89514d2 
> 
> Diff: http://git.reviewboard.kde.org/r/101065/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Border around contact avatar
>   http://git.reviewboard.kde.org/r/101065/s/118/
> 
> 
> Thanks,
> 
> Lukas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110409/1351d2c7/attachment.htm 


More information about the KDE-Telepathy mailing list