Review Request: Adds tooltips and avatar button support

[Keith Rusler]

> On April 2, 2011, 7:02 p.m., Martin Klapetek wrote:
> > main-widget.cpp, line 661
> > <http://git.reviewboard.kde.org/r/101012/diff/1/?file=13702#file13702line661>
> >
> >     Why is there so much &nbsp; ? If it is already a table, can't it be aligned with td?
> 
> Keith Rusler wrote:
>     I hate HTML, and it's been a while since I used it. So I forgotten a lot of it.
> 
> Martin Klapetek wrote:
>     I suggest you use only table elements here - <td> <tr> - don't use <br /> or &nbsp;.

well <br /> is used basically because some of them are in the same cell and need to be on their own line :).


- Keith


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101012/#review2316
-----------------------------------------------------------


On April 7, 2011, 11:14 p.m., Keith Rusler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101012/
> -----------------------------------------------------------
> 
> (Updated April 7, 2011, 11:14 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
>     - Added support for tooltips when hovering over a contact in the list.
>     - Added support for the avatar button at the top of the contact list.
>       Now it will load the avatar when connecting, though I'm not sure on
>       how to handle it if a protocol changed the avatar outside of telepathy.
>       If the avatar is big it will resize it, so you don't have a huge tooltip
>       when you hover your accounts.
> 
> 
> Diffs
> -----
> 
>   contact-delegate.h 20daa62 
>   contact-delegate.cpp 73f37e4 
>   main-widget.cpp 7bde815 
> 
> Diff: http://git.reviewboard.kde.org/r/101012/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Updated tooltip screenie
>   http://git.reviewboard.kde.org/r/101012/s/116/
> 
> 
> Thanks,
> 
> Keith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110407/f598396f/attachment.htm