Review Request: Fix Contacts On Load (attempt 2)

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101052/#review2472
-----------------------------------------------------------

Ship it!


- Martin


On April 7, 2011, 6:02 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101052/
> -----------------------------------------------------------
> 
> (Updated April 7, 2011, 6:02 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Make sure the ContactManager is ready before calling allKnownContacts, this was updated for connection changes, but not for when the connection existed on startup. This fixes that and removes some code duplication.
> 
> 
> Diffs
> -----
> 
>   accounts-model-item.cpp ad5368b2340f2ebb2f952d445c0f9f5253848bdb 
>   accounts-model-item.h 65e1c82da179c6c2072e55a5eb13002000b12739 
> 
> Diff: http://git.reviewboard.kde.org/r/101052/diff
> 
> 
> Testing
> -------
> 
> Loaded app, check I had contacts.
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110407/b70dac05/attachment.htm