Review Request: Error handling

David Edmundson kde at davidedmundson.co.uk
Thu Apr 7 18:45:59 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101049/#review2464
-----------------------------------------------------------


Mostly great - just need to wait for Martin's patch to roll in.
OR (probably better)
(if he agrees), merge this, and then he can sort it out as appropriate.


main-widget.cpp
<http://git.reviewboard.kde.org/r/101049/#comment2134>

    This bit is wrong - we need Martin's patch (not committed yet), and to merge these two together.


- David


On April 7, 2011, 4:33 p.m., Francesco Nwokeka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101049/
> -----------------------------------------------------------
> 
> (Updated April 7, 2011, 4:33 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Connected all simple pendingOperations to a single slot to notify user in case an error occurs. When an error occurs, a KMessageBox::Information dialog is shown with the error message inside
> 
> 
> Diffs
> -----
> 
>   main-widget.h e310b35 
>   main-widget.cpp 2e049a1 
> 
> Diff: http://git.reviewboard.kde.org/r/101049/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Francesco
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110407/4ccddc0c/attachment.htm 


More information about the KDE-Telepathy mailing list