Review Request: Initial avatars support

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101048/#review2463
-----------------------------------------------------------


Pretty solid patch.

You don't have anything that updates the image when it changes externally. This needs doing (you can make that a future thing, as long as you write it down somewhere).
Does this work when the first account is offline?


main-widget.h
<http://git.reviewboard.kde.org/r/101048/#comment2129>

    This needs merging with onGenericOperationFinished. (which you don't seem to have - update)



main-widget.cpp
<http://git.reviewboard.kde.org/r/101048/#comment2133>

    Try not to put multiple fixes into a review.



main-widget.cpp
<http://git.reviewboard.kde.org/r/101048/#comment2130>

    avatat -> avatar



main-widget.cpp
<http://git.reviewboard.kde.org/r/101048/#comment2132>

    Really you should do some KIO stuff here as KFileDialog can return something on the network, but QFile won't open it.
    
    For now I'd be happy with a comment that says it needs doing.



main-widget.cpp
<http://git.reviewboard.kde.org/r/101048/#comment2131>

    You don't close the image if everything processes correctly.
    
    Fortunately a QFile closes itself in the destructor, which means you don't actually need to do it all.


- David


On April 7, 2011, 3:33 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101048/
> -----------------------------------------------------------
> 
> (Updated April 7, 2011, 3:33 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> This patch adds initial avatars support plus KConfig, which holds the selected avatar.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 548e8c880b5ef921606c7407b92e2e1650faef86 
>   accounts-model-item.cpp 1d207e7eebb6d286d0fc075dfa4e90628ac92bcc 
>   main-widget.h e310b35d475509f5683a0abe15f21bbb1d8f122e 
>   main-widget.cpp 2e049a13561a1dc4ca0b7117a52ed713d775b9bd 
>   main-widget.ui bc1fb9bf030a927cf635ed1f73d71d6ee33675b2 
> 
> Diff: http://git.reviewboard.kde.org/r/101048/diff
> 
> 
> Testing
> -------
> 
> Tried to change the avatar and it worked.
> 
> 
> Screenshots
> -----------
> 
> Avatars menu
>   http://git.reviewboard.kde.org/r/101048/s/114/
> 
> 
> Thanks,
> 
> Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110407/362be99f/attachment.htm