Review Request: Remove Contacts from contact list patch

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101032/#review2431
-----------------------------------------------------------

Ship it!


Turns out to be a very good patch.
Make sure you run git add on the new .ui file (it's currently missing).
Update your copyright with your name especially on the new files.


remove-contact-dialog.cpp
<http://git.reviewboard.kde.org/r/101032/#comment2086>

    I think you're suffering from an identity crisis.
    
    Make sure to update this


- David


On April 6, 2011, 9:54 a.m., Francesco Nwokeka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101032/
> -----------------------------------------------------------
> 
> (Updated April 6, 2011, 9:54 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Implemented the "Delete user" action in the context menu of the contact list.
> The "delete" action removes the contact and blocks it.
> 
> For the moment this does not work 100% on all CM's but will as soon as things upstream are completley implemented/handled
> 
> 
> Diffs
> -----
> 
>   remove-contact-dialog.cpp PRE-CREATION 
>   CMakeLists.txt 4d737cf 
>   main-widget.h 6c45763 
>   main-widget.cpp 99c6761 
>   remove-contact-dialog.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/101032/diff
> 
> 
> Testing
> -------
> 
> Deleted a contact from google talk.
> 
> Doesn't work with butterfly CM.
> 
> 
> Screenshots
> -----------
> 
> Remove Contact Dialog
>   http://git.reviewboard.kde.org/r/101032/s/113/
> 
> 
> Thanks,
> 
> Francesco
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110406/85a902d7/attachment.htm