Review Request: Remove Contacts from contact list patch

[Francesco Nwokeka]

> On April 6, 2011, 9:58 a.m., Martin Klapetek wrote:
> > Looks great! Will it also work when you try to delete multiple contacts?

The "Remove contact" option is accessible only via context menu by clicking on the desired contact to remove.
I could implement the "delete multiple contacts" if you like, and put it next to the "add contact" icon.


- Francesco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101032/#review2429
-----------------------------------------------------------


On April 6, 2011, 9:54 a.m., Francesco Nwokeka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101032/
> -----------------------------------------------------------
> 
> (Updated April 6, 2011, 9:54 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Implemented the "Delete user" action in the context menu of the contact list.
> The "delete" action removes the contact and blocks it.
> 
> For the moment this does not work 100% on all CM's but will as soon as things upstream are completley implemented/handled
> 
> 
> Diffs
> -----
> 
>   remove-contact-dialog.cpp PRE-CREATION 
>   CMakeLists.txt 4d737cf 
>   main-widget.h 6c45763 
>   main-widget.cpp 99c6761 
>   remove-contact-dialog.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/101032/diff
> 
> 
> Testing
> -------
> 
> Deleted a contact from google talk.
> 
> Doesn't work with butterfly CM.
> 
> 
> Screenshots
> -----------
> 
> Remove Contact Dialog
>   http://git.reviewboard.kde.org/r/101032/s/113/
> 
> 
> Thanks,
> 
> Francesco
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110406/99f2a072/attachment.htm