Review Request: Remove Contacts from contact list patch
Francesco Nwokeka
francesco.nwokeka at gmail.com
Wed Apr 6 11:54:48 CEST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101032/
-----------------------------------------------------------
(Updated April 6, 2011, 9:54 a.m.)
Review request for Telepathy.
Changes
-------
~ Added removeContactDialog class with the option to block the contact as well as shown in the screenshot of this review.
~ used "slotGenericOperionFinished" for checking for errors when removing/blocking a contact.
~ added license on new class files
Summary
-------
Implemented the "Delete user" action in the context menu of the contact list.
The "delete" action removes the contact and blocks it.
For the moment this does not work 100% on all CM's but will as soon as things upstream are completley implemented/handled
Diffs (updated)
-----
remove-contact-dialog.cpp PRE-CREATION
CMakeLists.txt 4d737cf
main-widget.h 6c45763
main-widget.cpp 99c6761
remove-contact-dialog.h PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/101032/diff
Testing
-------
Deleted a contact from google talk.
Doesn't work with butterfly CM.
Screenshots
-----------
Remove Contact Dialog
http://git.reviewboard.kde.org/r/101032/s/113/
Thanks,
Francesco
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110406/5d79be8b/attachment.htm
More information about the KDE-Telepathy
mailing list