File Transfers in Preview Release

[Olli Salli]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 05.04.2011 03:25, Daniele E. Domenichelli wrote:
> On 04/05/2011 02:09 AM, Daniele E. Domenichelli wrote:
>> The idea was to replace it with a HandleFileTransferJob that implements
>> a Tp handler both for incoming and outgoing file transers (see the
>> implementation of HandleP2PDBusTubeJob vs. Accept/OfferDBusTubeJob).
> 
> 
> It should have been HandleFileTransferJob that implements a Tp handler
> both for incoming and outgoing file transfers and a
> RequestFileTransferJob to initiate a file transfer (see
> Handle/RequestP2PDBusTubeJob vs. Accept/OfferDBusTubeJob).
> 

Btw, implementing things like RequestFileTransferJob is much easier now
that we have the Request & Handle API in tp-qt4. The request & handle
variants of the Account channel request methods, such as
createAndHandleFileTransfer(), handle the complexity of dealing with the
channel dispatcher, being a suitable Handler etc internally. You just
fire the channel request, and when it comes back successfully, you have
a channel which you're guaranteed to (secretly) be the handler of i.e.
nobody else is handling it. This essentially matches the apparent
convenience of the naive approach of requesting channels directly from
the Connection bypassing the CD.

Br,
Olli
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJNmsN6AAoJEAQQkupGanj4Z5AH/3gUa47iQHhGhmT4lhxECEAd
mfGtAgZMX9Hc16NAP4E6K6IaLIJKDUFA9VXenXXJOI3EVSL1vIY8R8B/91HkSo19
cq51nGOZTF1TkywlrdVnaSiZFsXHKxN26FCTFySrD5hNG22ZchK7oq0VjBAN4i5o
0PfkXuy758bfV5t63Eq70RYXP3WKdJY4ULSP7msHXt8ndVBSam/poZIVmMzm/zGz
DsfpZdB345m3JubkZh6ArNC17kWRlkOUAaA4Cjc1QozLFUWHSnhtDIRDhlNAlZbF
GJiC3tRjTee+mwknp/bLL7lpcv8xlIf5YCcYXp82Fs4JoLRnekdV9IPVDoS8j2w=
=5rRi
-----END PGP SIGNATURE-----