File Transfers in Preview Release

[George Goldberg]

2011/4/4 David Edmundson <david at davidedmundson.co.uk>:
> In our first release of KDE Telepathy I want to have support of file
> transfers.
> I think it makes sense to use as much as possible from the KJobs
> (AcceptFileTransfer/OfferFileTransfer) that someone (Dario?/DrDanz?) has
> written in telepathy-kde (the lib)
> This leads to a few questions:
> 1) Which app should handle accepting an incoming file?
> the approver?
> 2) Are we still going to ship telepathy-kde in the non-nepomuk release?
> If so does anyone object to to modifying the jobs to the following:
>
>   OfferFileTransferJob(const Nepomuk::PersonContact& contact, QString
> filename, QObject* parent = 0);
>
>   OfferFileTransferJob(const Nepomuk::Person& metacontact, QString filename,
> QObject* parent = 0)
>
> + OfferFileTransferJob(const Tp::ContactPtr& contact, QString filename,
> QObject* parent = 0) <- this line would be new
>
> The first one would call the second one which would call the third one (in
> the internal private slots). To me it makes sense to read the flow of
> things, and exposes our jobs to every layer without any code
> duplication. This release we use the direct telepathy call, then in the
> future we use the two nepomuk ones as appropriate.
> OR
> Shall I make a new library just for this release which just copies and
> pastes code about from these classes (stripping out to be just the parts we
> want this time)

I can make a separate static lib in the telepathy-kde repo that we can
use for this. I'll get to it in the next two or three days.

--
George