Review Request: Fix Issues with no contacts appearing when first connnecting
Francesco Nwokeka
francesco.nwokeka at gmail.com
Mon Apr 4 09:25:05 CEST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101023/#review2373
-----------------------------------------------------------
Ship it!
Looks all good to me
- Francesco
On April 4, 2011, 12:10 a.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101023/
> -----------------------------------------------------------
>
> (Updated April 4, 2011, 12:10 a.m.)
>
>
> Review request for Telepathy.
>
>
> Summary
> -------
>
> Only load contacts when ContactManager is ready, reduces chance of having an empty contact list on first connect/load.
>
> Martin - if this patch gets approved, could you merge this into our upstream repo for Tp-Yell.
>
>
> Diffs
> -----
>
> accounts-model-item.h 65e1c82da179c6c2072e55a5eb13002000b12739
> accounts-model-item.cpp ad5368b2340f2ebb2f952d445c0f9f5253848bdb
>
> Diff: http://git.reviewboard.kde.org/r/101023/diff
>
>
> Testing
> -------
>
> compiled + loaded up. All contacts appeared.
>
>
> Thanks,
>
> David
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110404/ee90174a/attachment.htm
More information about the KDE-Telepathy
mailing list