Review Request: Enable next/previous search buttons only when needed

Francesco Nwokeka francesco.nwokeka at gmail.com
Sun Apr 3 17:12:20 CEST 2011



> On April 3, 2011, 2:53 p.m., Martin Klapetek wrote:
> > app/chat-window.cpp, line 171
> > <http://git.reviewboard.kde.org/r/101017/diff/2/?file=13723#file13723line171>
> >
> >     Just a small nitpick, the name of this method should probably be enableSearchActions() so it is more clearer that you're toggling the menu actions and not buttons.

Done


- Francesco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101017/#review2353
-----------------------------------------------------------


On April 3, 2011, 2:46 p.m., Francesco Nwokeka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101017/
> -----------------------------------------------------------
> 
> (Updated April 3, 2011, 2:46 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Simple patch that disables the next and previous buttons in the search bar when there is no text to look for.
> Requested by martin
> 
> 
> Diffs
> -----
> 
>   app/chat-window.h 45ba617 
>   app/chat-window.cpp 0725ca6 
>   lib/chat-search-bar.h 796280f 
>   lib/chat-search-bar.cpp 6b137b3 
> 
> Diff: http://git.reviewboard.kde.org/r/101017/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Francesco
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110403/84971a8a/attachment.htm 


More information about the KDE-Telepathy mailing list