Review Request: Adds tooltips and avatar button support

[Martin Klapetek]

> On April 2, 2011, 7:02 p.m., Martin Klapetek wrote:
> > Will you also do the full dialog for the user info?
> 
> Keith Rusler wrote:
>     Yes I will. But I'll do it in another patch, if that is only with you?

Totally :)


> On April 2, 2011, 7:02 p.m., Martin Klapetek wrote:
> > CMakeLists.txt, line 52
> > <http://git.reviewboard.kde.org/r/101012/diff/1/?file=13700#file13700line52>
> >
> >     Are we using KIO now?
> 
> Keith Rusler wrote:
>     It's required for KFileDialog

Ah ok then.


> On April 2, 2011, 7:02 p.m., Martin Klapetek wrote:
> > main-widget.cpp, line 661
> > <http://git.reviewboard.kde.org/r/101012/diff/1/?file=13702#file13702line661>
> >
> >     Why is there so much &nbsp; ? If it is already a table, can't it be aligned with td?
> 
> Keith Rusler wrote:
>     I hate HTML, and it's been a while since I used it. So I forgotten a lot of it.

I suggest you use only table elements here - <td> <tr> - don't use <br /> or &nbsp;.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101012/#review2316
-----------------------------------------------------------


On April 2, 2011, 6:42 p.m., Keith Rusler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101012/
> -----------------------------------------------------------
> 
> (Updated April 2, 2011, 6:42 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
>     - Added support for tooltips when hovering over a contact in the list.
>     - Added support for the avatar button at the top of the contact list.
>       Now it will load the avatar when connecting, though I'm not sure on
>       how to handle it if a protocol changed the avatar outside of telepathy.
>       If the avatar is big it will resize it, so you don't have a huge tooltip
>       when you hover your accounts.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 7581f10 
>   main-widget.h daa6559 
>   main-widget.cpp f65d7fd 
> 
> Diff: http://git.reviewboard.kde.org/r/101012/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Keith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110402/05a0aa90/attachment.htm