Review Request: Fix activation of the "Find" shortcut
Dario Freddi
drf at kde.org
Fri Apr 1 20:31:52 CEST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101001/#review2306
-----------------------------------------------------------
Ship it!
Not the cleanest solution, but it works nice, good job.
P.S.: See, I don't bite (everytime ;) )
- Dario
On April 1, 2011, 5:30 p.m., Francesco Nwokeka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101001/
> -----------------------------------------------------------
>
> (Updated April 1, 2011, 5:30 p.m.)
>
>
> Review request for Telepathy.
>
>
> Summary
> -------
>
> The "find" shortcut wasn't being called anymore because ovveridden by the introduction of KTextEdit for the inheritance of "ChatTextEdit". So what I basically did was to overload the "keyPressEvent(QKeyEvent* e)" and emit a custom signal
>
>
> Diffs
> -----
>
> lib/chat-text-edit.h ba46e39
> lib/chat-text-edit.cpp a24c7ff
> lib/chat-widget.cpp 33bd5c9
>
> Diff: http://git.reviewboard.kde.org/r/101001/diff
>
>
> Testing
> -------
>
> spammed "ctrl+f" on a text chat
>
>
> Thanks,
>
> Francesco
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110401/48c4a390/attachment.htm
More information about the KDE-Telepathy
mailing list