Review Request: Added a mechanism to add new contacts.

[Dario Freddi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101008/#review2305
-----------------------------------------------------------

Ship it!


Apart from a pair of very small issues, just one thing to fix, then it is set to go. Marking as Ship it! as I trust you in fixing them before merging.


add-contact-dialog.h
<http://git.reviewboard.kde.org/r/101008/#comment1990>

    Probably we're better off in making this virtual



add-contact-dialog.cpp
<http://git.reviewboard.kde.org/r/101008/#comment1987>

    } else {



main-widget.cpp
<http://git.reviewboard.kde.org/r/101008/#comment1988>

    This is a common potentially risky situation which can be avoided as explained here: http://www.kdedevelopers.org/node/3919 (very interesting read).
    
    The article is a bit outdated, of course now you would use QWeakPointer instead of QPointer.



main-widget.cpp
<http://git.reviewboard.kde.org/r/101008/#comment1989>

    } else {


- Dario


On April 1, 2011, 6:16 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101008/
> -----------------------------------------------------------
> 
> (Updated April 1, 2011, 6:16 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> This consists of a new dialog for selecting accounts and typing screen name and code in the mainwidget for using this to perform the actual adding.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 7581f1026f1f98e00a44e3f900c226ef12aff664 
>   add-contact-dialog.h PRE-CREATION 
>   add-contact-dialog.cpp PRE-CREATION 
>   add-contact-dialog.ui PRE-CREATION 
>   main-widget.h daa65597561f7dfa5ed03f80bb5e800366b456ab 
>   main-widget.cpp e8d9258f19578e7fe0527bf731876747fd720352 
> 
> Diff: http://git.reviewboard.kde.org/r/101008/diff
> 
> 
> Testing
> -------
> 
> Added some contacts within my local jabber server.
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110401/14d6e220/attachment.htm