Review Request: Implement the Main/Advanced option split scheme in the telepathy-accounts-kcm

[Gustavo Boiko]

> On 2010-09-28 20:32:59, George Goldberg wrote:
> > One further issue - the basic-options widget doesn't display properly for me in either the add or edit windows - it just takes up a small rectangle at the top left of the dialog and I can't even get at the scrollbars etc. Something a bit weird going on there.

That's because the plugins aren't yet prepared to this new scheme. I haven't finished porting them, but I can put online a diff of the current stage (which is already enough to test the changes in the kcm module itself).


- Gustavo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5467/#review7860
-----------------------------------------------------------


On 2010-09-28 21:00:18, Gustavo Boiko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5467/
> -----------------------------------------------------------
> 
> (Updated 2010-09-28 21:00:18)
> 
> 
> Review request for telepathy.
> 
> 
> Summary
> -------
> 
> This patch implements the config scheme discussed in the mailing list. The account edit dialog now shows only one dialog containing all the main options for the protocol, and optionally an advanced button which opens one second dialog containing extra options.
> 
> There is no more distinction between mandatory and optional arguments, but the dialog ensures all mandatory arguments are handle, falling back to a generic dialog if they are not.
> 
> The patch also simplifies the loading of configuration widgets by creating the AccountEditDialog, which does all the job of loading the dialogs. This dialog is used by both the EditAccountDialog and the AddAccountWizard. It will also be used in the Kopete Telepathy plugin (I will work on this right after this one gets in).
> 
> The port of the plugins to this new scheme is already being done.
> 
> 
> Diffs
> -----
> 
>   /trunk/playground/network/telepathy-accounts-kcm/src/KCMTelepathyAccounts/protocol-item.h 1180721 
>   /trunk/playground/network/telepathy-accounts-kcm/src/KCMTelepathyAccounts/protocol-item.cpp 1180721 
>   /trunk/playground/network/telepathy-accounts-kcm/src/add-account-assistant.cpp 1179066 
>   /trunk/playground/network/telepathy-accounts-kcm/src/edit-account-dialog.h 1179066 
>   /trunk/playground/network/telepathy-accounts-kcm/src/edit-account-dialog.cpp 1179066 
>   /trunk/playground/network/telepathy-accounts-kcm/src/KCMTelepathyAccounts/abstract-account-ui.cpp 1180721 
>   /trunk/playground/network/telepathy-accounts-kcm/src/KCMTelepathyAccounts/account-edit-widget.h PRE-CREATION 
>   /trunk/playground/network/telepathy-accounts-kcm/src/KCMTelepathyAccounts/account-edit-widget.cpp PRE-CREATION 
>   /trunk/playground/network/telepathy-accounts-kcm/src/KCMTelepathyAccounts/account-edit-widget.ui PRE-CREATION 
>   /trunk/playground/network/telepathy-accounts-kcm/src/KCMTelepathyAccounts/include/AccountEditWidget PRE-CREATION 
>   /trunk/playground/network/telepathy-accounts-kcm/src/KCMTelepathyAccounts/include/MandatoryParameterEditWidget 1179066 
>   /trunk/playground/network/telepathy-accounts-kcm/src/KCMTelepathyAccounts/include/OptionalParameterEditWidget 1179066 
>   /trunk/playground/network/telepathy-accounts-kcm/src/KCMTelepathyAccounts/mandatory-parameter-edit-widget.h 1179066 
>   /trunk/playground/network/telepathy-accounts-kcm/src/KCMTelepathyAccounts/mandatory-parameter-edit-widget.cpp 1179066 
>   /trunk/playground/network/telepathy-accounts-kcm/src/KCMTelepathyAccounts/optional-parameter-edit-widget.h 1179066 
>   /trunk/playground/network/telepathy-accounts-kcm/src/KCMTelepathyAccounts/optional-parameter-edit-widget.cpp 1179066 
>   /trunk/playground/network/telepathy-accounts-kcm/src/KCMTelepathyAccounts/CMakeLists.txt 1180721 
>   /trunk/playground/network/telepathy-accounts-kcm/src/KCMTelepathyAccounts/abstract-account-ui.h 1180721 
> 
> Diff: http://svn.reviewboard.kde.org/r/5467/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gustavo
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20100928/264c4941/attachment.htm