Review Request: Use telepathy-qt4 constants instead of numeric constants
Dario Freddi
drf54321 at gmail.com
Fri May 28 12:18:16 CEST 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4170/#review5899
-----------------------------------------------------------
Ship it!
- Dario
On 2010-05-28 09:50:43, Daniele E. Domenichelli wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4170/
> -----------------------------------------------------------
>
> (Updated 2010-05-28 09:50:43)
>
>
> Review request for telepathy.
>
>
> Summary
> -------
>
> Very small patch...
> In file contact-item.cpp numeric constants are used to check the contact status.
> using telepathy-qt4 constants the code is more readable and safe in case of api changes.
>
>
> Diffs
> -----
>
> /trunk/playground/network/telepathy-contactlist/contact-item.cpp 1130253
>
> Diff: http://reviewboard.kde.org/r/4170/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Daniele E.
>
>
More information about the KDE-Telepathy
mailing list