Review Request: Add Telepathy capabilities to tp-contactlist, and enable removing/adding contacts from/to a group

[Dario Freddi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3415/
-----------------------------------------------------------

(Updated 2010-03-29 22:33:35.231359)


Review request for telepathy and George Goldberg.


Changes
-------

And for the final feature round (this patch is getting a bit too big), working addition/removal of contacts!! (as usual tested with Empathy, it works pretty nice).

Some caveats described in // TODOs around.

Also, the SPARQL query for getting the local accounts does not really work, but now it's starting to become a personal issue with SPARQL so I'll try fixing it in my spare time before getting to bed, and eventually update the MR tomorrow.


Summary
-------

This patch adds two new classes (already ready to be librarized) for creating a Nepomuk->Telepathy bridge, making it very easy to retrieve Telepathy objects out of Nepomuk resources. Performance overhead looks trascurable.

By using this new class, contactlist is now able to add/remove people from a group.

Error handling is still missing, but I wanted an heads up before I go on and implement all the rest.

Also, how are we going to handle metacontacts in this particular regard? My take is to move/remove all contacts to/out of a group, and eventually creating a group for those accounts who still don't have a group named as such in case of addition.

Beware: until t-i-d will be able to catch these changes and update nepomuk accordingly, this is probably going to screw up your nepomuk DB when moving contacts around groups.


Diffs (updated)
-----

  /trunk/playground/network/telepathy-contactlist/CMakeLists.txt 1107773 
  /trunk/playground/network/telepathy-contactlist/add-contact-job.h PRE-CREATION 
  /trunk/playground/network/telepathy-contactlist/add-contact-job.cpp PRE-CREATION 
  /trunk/playground/network/telepathy-contactlist/add-contacts-to-group-job.h PRE-CREATION 
  /trunk/playground/network/telepathy-contactlist/add-contacts-to-group-job.cpp PRE-CREATION 
  /trunk/playground/network/telepathy-contactlist/contact-item.h 1107996 
  /trunk/playground/network/telepathy-contactlist/contact-item.cpp 1107996 
  /trunk/playground/network/telepathy-contactlist/main-widget.h 1107996 
  /trunk/playground/network/telepathy-contactlist/main-widget.cpp 1107996 
  /trunk/playground/network/telepathy-contactlist/main-widget.ui 1107667 
  /trunk/playground/network/telepathy-contactlist/meta-contact-item.h 1107996 
  /trunk/playground/network/telepathy-contactlist/meta-contact-item.cpp 1107996 
  /trunk/playground/network/telepathy-contactlist/remove-contacts-from-group-job.h PRE-CREATION 
  /trunk/playground/network/telepathy-contactlist/remove-contacts-from-group-job.cpp PRE-CREATION 
  /trunk/playground/network/telepathy-contactlist/remove-contacts-job.h PRE-CREATION 
  /trunk/playground/network/telepathy-contactlist/remove-contacts-job.cpp PRE-CREATION 
  /trunk/playground/network/telepathy-contactlist/telepathy-account-proxy.h PRE-CREATION 
  /trunk/playground/network/telepathy-contactlist/telepathy-account-proxy.cpp PRE-CREATION 
  /trunk/playground/network/telepathy-contactlist/telepathy-base-job.h PRE-CREATION 
  /trunk/playground/network/telepathy-contactlist/telepathy-base-job.cpp PRE-CREATION 
  /trunk/playground/network/telepathy-contactlist/telepathy-base-job_p.h PRE-CREATION 
  /trunk/playground/network/telepathy-contactlist/telepathy-bridge.h PRE-CREATION 
  /trunk/playground/network/telepathy-contactlist/telepathy-bridge.cpp PRE-CREATION 
  /trunk/playground/network/telepathy-contactlist/telepathy-bridge_p.h PRE-CREATION 

Diff: http://reviewboard.kde.org/r/3415/diff


Testing
-------

Works, empathy recognizes the changes correctly.


Thanks,

Dario