Review Request: Add Telepathy capabilities to tp-contactlist, and enable removing/adding contacts from/to a group
Dario Freddi
drf54321 at gmail.com
Mon Mar 29 00:04:42 CEST 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3415/
-----------------------------------------------------------
(Updated 2010-03-28 22:04:42.472646)
Review request for telepathy and George Goldberg.
Changes
-------
To speed up review times, I also added the future methods of TelepathyBridge with corresponding API docs.
Summary
-------
This patch adds two new classes (already ready to be librarized) for creating a Nepomuk->Telepathy bridge, making it very easy to retrieve Telepathy objects out of Nepomuk resources. Performance overhead looks trascurable.
By using this new class, contactlist is now able to add/remove people from a group.
Error handling is still missing, but I wanted an heads up before I go on and implement all the rest.
Also, how are we going to handle metacontacts in this particular regard? My take is to move/remove all contacts to/out of a group, and eventually creating a group for those accounts who still don't have a group named as such in case of addition.
Beware: until t-i-d will be able to catch these changes and update nepomuk accordingly, this is probably going to screw up your nepomuk DB when moving contacts around groups.
Diffs (updated)
-----
/trunk/playground/network/telepathy-contactlist/CMakeLists.txt 1107773
/trunk/playground/network/telepathy-contactlist/contact-item.h 1107996
/trunk/playground/network/telepathy-contactlist/contact-item.cpp 1107996
/trunk/playground/network/telepathy-contactlist/main-widget.h 1107996
/trunk/playground/network/telepathy-contactlist/main-widget.cpp 1107996
/trunk/playground/network/telepathy-contactlist/main-widget.ui 1107667
/trunk/playground/network/telepathy-contactlist/meta-contact-item.h 1107996
/trunk/playground/network/telepathy-contactlist/meta-contact-item.cpp 1107996
/trunk/playground/network/telepathy-contactlist/telepathy-account-proxy.h PRE-CREATION
/trunk/playground/network/telepathy-contactlist/telepathy-account-proxy.cpp PRE-CREATION
/trunk/playground/network/telepathy-contactlist/telepathy-bridge.h PRE-CREATION
/trunk/playground/network/telepathy-contactlist/telepathy-bridge.cpp PRE-CREATION
Diff: http://reviewboard.kde.org/r/3415/diff
Testing
-------
Works, empathy recognizes the changes correctly.
Thanks,
Dario
More information about the KDE-Telepathy
mailing list