Review Request: Add support for avatars in tp-contactlist

[George Goldberg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3409/#review4692
-----------------------------------------------------------

Ship it!


As with the other patch, the code looks fine, and I'll actually test later.

- George


On 2010-03-27 10:11:34, Dario Freddi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3409/
> -----------------------------------------------------------
> 
> (Updated 2010-03-27 10:11:34)
> 
> 
> Review request for telepathy and George Goldberg.
> 
> 
> Summary
> -------
> 
> This patch (obviously dependent on the previous one) shows (if present) the contact's avatar instead of the status icon in the contact list. The status icon is nicely overlayed upon the contact's avatar.
> 
> The ItemDelegate is just a quick proof of concept: I'll come up with a better one as soon as some mockups will start rolling.
> 
> 
> Diffs
> -----
> 
>   /trunk/playground/network/telepathy-contactlist/contact-item.h 1107667 
>   /trunk/playground/network/telepathy-contactlist/contact-item.cpp 1107667 
>   /trunk/playground/network/telepathy-contactlist/contacts-list-model.h 1107667 
>   /trunk/playground/network/telepathy-contactlist/contacts-list-model.cpp 1107667 
>   /trunk/playground/network/telepathy-contactlist/main-widget.h 1107667 
>   /trunk/playground/network/telepathy-contactlist/main-widget.cpp 1107667 
>   /trunk/playground/network/telepathy-contactlist/meta-contact-item.h 1107667 
>   /trunk/playground/network/telepathy-contactlist/meta-contact-item.cpp 1107667 
> 
> Diff: http://reviewboard.kde.org/r/3409/diff
> 
> 
> Testing
> -------
> 
> Works nicely
> 
> 
> Thanks,
> 
> Dario
> 
>