Review Request: Add support for avatars in telepathy-integration-daemon
Dario Freddi
drf54321 at gmail.com
Sat Mar 27 11:06:53 CET 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3408/
-----------------------------------------------------------
Review request for telepathy and George Goldberg.
Summary
-------
This patch adds support for avatars into tp-integration-daemon. It stores the avatar data inside Nepomuk (together with an avatar token given by telepathy) into nco:photo. A new field in the ontology was added to store the avatar token.
I also had to add an hash to store contacts -> TelepathyContacts. At the moment the hashing is done through Tp::ContactPtr, but we should definitely look into a better way. More than that, everything else appears to be ok.
Diffs
-----
/trunk/playground/network/telepathy-integration-daemon/telepathy.trig 1107667
/trunk/playground/network/telepathy-integration-daemon/telepathyaccount.h 1107667
/trunk/playground/network/telepathy-integration-daemon/telepathyaccount.cpp 1107667
/trunk/playground/network/telepathy-integration-daemon/telepathycontact.h 1107667
/trunk/playground/network/telepathy-integration-daemon/telepathycontact.cpp 1107667
Diff: http://reviewboard.kde.org/r/3408/diff
Testing
-------
Works, see next patch to have a proof :)
Thanks,
Dario
More information about the KDE-Telepathy
mailing list