Review Request: Removed accounts not updated in Nepomuk

[Dario Freddi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3784/#review5259
-----------------------------------------------------------


I don't think this patch would be actually effective for our case: cleaning the data for status & co is really not enough, considered how we access Nepomuk resources. See my comments below.


/trunk/playground/network/telepathy-integration-daemon/telepathyaccountmonitor.cpp
<http://reviewboard.kde.org/r/3784/#comment4758>

    As already stated in the previous comment, I don't really understand what's that good for



/trunk/playground/network/telepathy-integration-daemon/telepathyaccountmonitor.cpp
<http://reviewboard.kde.org/r/3784/#comment4759>

    How is this one going to help in removing contacts? This will not delete the IMAccount from the database, and takes no action over the contacts associated to this account. What you would end up in would be having the contactlist showing all the contacts belonging to the deleted accounts, but marked as offline.
    
    I think a better approach would be removing the account from me's groundingOccurrences. This way, you would end up retaining into the database all the relevant data, but the various queries would not retrieve the removed account.
    
    As a bonus point, this approach is consistent with what we do with contacts (we "cut off" isBuddyOf property but still won't delete a thing), and whenever a new account gets added, you can check if there is already a matching resource.


- Dario


On 2010-04-23 11:13:26, Daniele E. Domenichelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3784/
> -----------------------------------------------------------
> 
> (Updated 2010-04-23 11:13:26)
> 
> 
> Review request for telepathy and George Goldberg.
> 
> 
> Summary
> -------
> 
> When an account is removed from telepathy-mission-control, Nepomuk data is not updated.
> This means that, for example, if last status for a removed account was online, querying Nepomuk will always return that account among other existing accounts and will always affirm that removed account is online.
> 
> This patch sets statusType property to Tp::ConnectionPresenceTypeUnset in Nepomuk before creating accounts. Later, statusType is updated only for existing accounts, not for removed ones.
> Also adds "onAccountRemoved" slot that resets statusType to Tp::ConnectionPresenceTypeUnset when account is removed.
> 
> 
> Diffs
> -----
> 
>   /trunk/playground/network/telepathy-integration-daemon/telepathyaccountmonitor.h 1116405 
>   /trunk/playground/network/telepathy-integration-daemon/telepathyaccountmonitor.cpp 1116405 
> 
> Diff: http://reviewboard.kde.org/r/3784/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniele E.
> 
>