Review Request: Add contact request should be enabled only for online accounts

George Goldberg grundleborg at googlemail.com
Fri Apr 23 18:12:16 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3785/#review5186
-----------------------------------------------------------

Ship it!


Looks fine to me.

- George


On 2010-04-23 11:14:58, Daniele E. Domenichelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3785/
> -----------------------------------------------------------
> 
> (Updated 2010-04-23 11:14:58)
> 
> 
> Review request for telepathy and George Goldberg.
> 
> 
> Summary
> -------
> 
> When "add contact" button is clicked, all accounts in Nepomuk are shown, included removed, offline, ecc.
> This patch filters account before adding them.
> 
> 
> Diffs
> -----
> 
>   /trunk/playground/network/telepathy-contactlist/main-widget.cpp 1116405 
> 
> Diff: http://reviewboard.kde.org/r/3785/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniele E.
> 
>



More information about the KDE-Telepathy mailing list